Skip to content

doc: Adds example & documentation for new mongodbatlas_team_project_assignment resource #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: CLOUDP-320243-dev-2.0.0
Choose a base branch
from
Open

doc: Adds example & documentation for new mongodbatlas_team_project_assignment resource #3581

wants to merge 9 commits into from
+187 −1

Conversation

csanx
Copy link
Collaborator

@csanx csanx commented Aug 11, 2025

Description

Adds example & documentation for new mongodbatlas_team_project_assignment resource

Link to any related issue(s):CLOUDP-334646

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

All placeholders will be addressed as part of this ticket CLOUDP-329711

@csanx csanx marked this pull request as ready for review August 13, 2025 09:22
@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 09:22
@csanx csanx requested review from a team as code owners August 13, 2025 09:22
Copilot
Copilot AI reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

EspenAlbert
EspenAlbert reviewed Aug 13, 2025
View reviewed changes
examples/mongodbatlas_team_project_assignment/README.md Outdated
private_key = var.private_key
}
resource "mongodbatlas_team_project_assignment" "example" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Consider using this instead of example (Applies to all files) https://www.terraform-best-practices.com/naming

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you. Changed it

EspenAlbert
EspenAlbert reviewed Aug 13, 2025
View reviewed changes
examples/mongodbatlas_team_project_assignment/variables.tf

variable "private_key" {
description = "Atlas API private key"
type = string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add default = "" so the example can be run with env-vars to authenticate

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Added it to the other docs PR as well #3578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspenAlbert EspenAlbert EspenAlbert left review comments

Copilot code review Copilot Copilot left review comments

@marcosuma marcosuma marcosuma approved these changes

@maastha maastha maastha approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csanx @EspenAlbert @marcosuma @maastha